Add sorting_column to Field#2659
Merged
nickcharlton merged 1 commit intothoughtbot:mainfrom Feb 17, 2025
Merged
Conversation
c4f4703 to
fe11e6a
Compare
Contributor
Author
|
I rebased after #2658 was merged and made a few additional fixes. |
fe11e6a to
4c91e62
Compare
Contributor
Author
|
I feel that we need to discuss the option name. |
4c91e62 to
4fc6c46
Compare
Member
|
Hmm, yeah, the column names aren't great. At least Could you add some docs to it? |
4fc6c46 to
78ca367
Compare
Contributor
Author
|
@nickcharlton I have added the documentation. Please take a look. |
This takes the sortable field previously explored in thoughtbot#2658. Here, we allow overriding the sorting column on a field, plus turn off sorting if it wouldn't make sense for the given data.
78ca367 to
1a92f62
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've split the Sortable from #2658.
Usage